Commit 1b48773f authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: fix io_drain_req() 



io_drain_req() return whether the request has been consumed or not, not
an error code. Fix a stupid mistake slipped from optimisation patches.

Reported-by: default avatar <syzbot+ba6fcd859210f4e9e109@syzkaller.appspotmail.com>
Fixes: 76cc33d7 ("io_uring: refactor io_req_defer()")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/4d3c53c4274ffff307c8ae062fc7fda63b978df2.1626039606.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9c688260

fs/io_uring.c

+4 −2
Original line number Diff line number Diff line
@@ -6019,11 +6019,13 @@ static bool io_drain_req(struct io_kiocb *req) 


	ret = io_req_prep_async(req);

	if (ret)

		return ret;

		goto fail;

	io_prep_async_link(req);

	de = kmalloc(sizeof(*de), GFP_KERNEL);

	if (!de) {

		io_req_complete_failed(req, -ENOMEM);

		ret = -ENOMEM;

fail:

		io_req_complete_failed(req, ret);

		return true;

	}