Commit 1b3565db authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans Verkuil
Browse files

media: i2c: imx296: fix error checking in imx296_read_temperature() 



The "& IMX296_TMDOUT_MASK" means that "tmdout" can't be negative so the
error checking will not work.

Fixes: cb33db2b ("media: i2c: IMX296 camera sensor driver")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 2674486a

drivers/media/i2c/imx296.c

+3 −1
Original line number Diff line number Diff line
@@ -922,10 +922,12 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp) 
	if (ret < 0)

		return ret;



	tmdout = imx296_read(sensor, IMX296_TMDOUT) & IMX296_TMDOUT_MASK;

	tmdout = imx296_read(sensor, IMX296_TMDOUT);

	if (tmdout < 0)

		return tmdout;



	tmdout &= IMX296_TMDOUT_MASK;



	/* T(°C) = 246.312 - 0.304 * TMDOUT */;

	*temp = 246312 - 304 * tmdout;