Commit 1b3086b6 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

mxser: use port variable in mxser_set_serial_info 



mxser_set_serial_info already defined a local 'port' of type struct
tty_port. So use it in the code everywhere.

This eliminates some text from the code there.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-65-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 202acdaa

drivers/tty/mxser.c

+5 −5
Original line number Diff line number Diff line
@@ -1080,14 +1080,14 @@ static int mxser_set_serial_info(struct tty_struct *tty, 


	if (!capable(CAP_SYS_ADMIN)) {

		if ((ss->baud_base != MXSER_BAUD_BASE) ||

				(close_delay != info->port.close_delay) ||

				(closing_wait != info->port.closing_wait) ||

				((ss->flags & ~ASYNC_USR_MASK) != (info->port.flags & ~ASYNC_USR_MASK))) {

				(close_delay != port->close_delay) ||

				(closing_wait != port->closing_wait) ||

				((ss->flags & ~ASYNC_USR_MASK) != (port->flags & ~ASYNC_USR_MASK))) {

			mutex_unlock(&port->mutex);

			return -EPERM;

		}

		info->port.flags = ((info->port.flags & ~ASYNC_USR_MASK) |

				(ss->flags & ASYNC_USR_MASK));

		port->flags = (port->flags & ~ASYNC_USR_MASK) |

				(ss->flags & ASYNC_USR_MASK);

	} else {

		/*

		 * OK, past this point, all the error checking has been done.