Commit 1b0e3186 authored by Eric Biggers's avatar Eric Biggers Committed by Linus Torvalds
Browse files

nilfs2: only call unlock_new_inode() if I_NEW 



Patch series "nilfs2 updates".

This patch (of 3):

unlock_new_inode() is only meant to be called after a new inode has
already been inserted into the hash table.  But nilfs_new_inode() can call
it even before it has inserted the inode, triggering the WARNING in
unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
inode has the I_NEW flag set, indicating that it's in the table.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/1595860111-3920-1-git-send-email-konishi.ryusuke@gmail.com
Link: http://lkml.kernel.org/r/1595860111-3920-2-git-send-email-konishi.ryusuke@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f666f9fb

fs/nilfs2/inode.c

+2 −1
Original line number Diff line number Diff line
@@ -388,6 +388,7 @@ struct inode *nilfs_new_inode(struct inode *dir, umode_t mode) 


 failed_after_creation:

	clear_nlink(inode);

	if (inode->i_state & I_NEW)

		unlock_new_inode(inode);

	iput(inode);  /*

		       * raw_inode will be deleted through