Commit 1afaf5cb authored by SeongJae Park's avatar SeongJae Park Committed by Linus Torvalds
Browse files

mm/damon/core: remove unnecessary error messages 

DAMON core prints error messages when damon_target object creation is
failed or wrong monitoring attributes are given.  Because appropriate
error code is returned for each case, the messages are not essential.
Also, because the code path can be triggered with user-specified input,
this could result in kernel log mistakenly being messy.  To avoid the
case, this commit removes the messages.

Link: https://lkml.kernel.org/r/20211201150440.1088-4-sj@kernel.org


Fixes: 4bc05954 ("mm/damon: implement a debugfs-based user space interface")
Fixes: b9a6ac4e ("mm/damon: adaptively adjust regions")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: kernel test robot <lkp@intel.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0bceffa2

mm/damon/core.c

+2 −9
Original line number Diff line number Diff line
@@ -282,7 +282,6 @@ int damon_set_targets(struct damon_ctx *ctx, 
	for (i = 0; i < nr_ids; i++) {

		t = damon_new_target(ids[i]);

		if (!t) {

			pr_err("Failed to alloc damon_target\n");

			/* The caller should do cleanup of the ids itself */

			damon_for_each_target_safe(t, next, ctx)

				damon_destroy_target(t);
@@ -312,16 +311,10 @@ int damon_set_attrs(struct damon_ctx *ctx, unsigned long sample_int, 
		    unsigned long aggr_int, unsigned long primitive_upd_int,

		    unsigned long min_nr_reg, unsigned long max_nr_reg)

{

	if (min_nr_reg < 3) {

		pr_err("min_nr_regions (%lu) must be at least 3\n",

				min_nr_reg);

	if (min_nr_reg < 3)

		return -EINVAL;

	}

	if (min_nr_reg > max_nr_reg) {

		pr_err("invalid nr_regions.  min (%lu) > max (%lu)\n",

				min_nr_reg, max_nr_reg);

	if (min_nr_reg > max_nr_reg)

		return -EINVAL;

	}



	ctx->sample_interval = sample_int;

	ctx->aggr_interval = aggr_int;