Commit 1af5a810 authored by Alistair Popple's avatar Alistair Popple Committed by Andrew Morton
Browse files

mmu_notifiers: rename invalidate_range notifier 

There are two main use cases for mmu notifiers.  One is by KVM which uses
mmu_notifier_invalidate_range_start()/end() to manage a software TLB.

The other is to manage hardware TLBs which need to use the
invalidate_range() callback because HW can establish new TLB entries at
any time.  Hence using start/end() can lead to memory corruption as these
callbacks happen too soon/late during page unmap.

mmu notifier users should therefore either use the start()/end() callbacks
or the invalidate_range() callbacks.  To make this usage clearer rename
the invalidate_range() callback to arch_invalidate_secondary_tlbs() and
update documention.

Link: https://lkml.kernel.org/r/6f77248cd25545c8020a54b4e567e8b72be4dca1.1690292440.git-series.apopple@nvidia.com


Signed-off-by: default avatarAlistair Popple <apopple@nvidia.com>
Suggested-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Cc: Andrew Donnellan <ajd@linux.ibm.com>
Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Cc: Frederic Barrat <fbarrat@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: SeongJae Park <sj@kernel.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Will Deacon <will@kernel.org>
Cc: Zhi Wang <zhi.wang.linux@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent ec8832d0

arch/arm64/include/asm/tlbflush.h

+3 −3
Original line number Diff line number Diff line
@@ -253,7 +253,7 @@ static inline void flush_tlb_mm(struct mm_struct *mm) 
	__tlbi(aside1is, asid);

	__tlbi_user(aside1is, asid);

	dsb(ish);

	mmu_notifier_invalidate_range(mm, 0, -1UL);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);

}



static inline void __flush_tlb_page_nosync(struct mm_struct *mm,
@@ -265,7 +265,7 @@ static inline void __flush_tlb_page_nosync(struct mm_struct *mm, 
	addr = __TLBI_VADDR(uaddr, ASID(mm));

	__tlbi(vale1is, addr);

	__tlbi_user(vale1is, addr);

	mmu_notifier_invalidate_range(mm, uaddr & PAGE_MASK,

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, uaddr & PAGE_MASK,

						(uaddr & PAGE_MASK) + PAGE_SIZE);

}
@@ -400,7 +400,7 @@ static inline void __flush_tlb_range(struct vm_area_struct *vma, 
		scale++;

	}

	dsb(ish);

	mmu_notifier_invalidate_range(vma->vm_mm, start, end);

	mmu_notifier_arch_invalidate_secondary_tlbs(vma->vm_mm, start, end);

}



static inline void flush_tlb_range(struct vm_area_struct *vma,

arch/powerpc/mm/book3s64/radix_hugetlbpage.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ void radix__flush_hugetlb_tlb_range(struct vm_area_struct *vma, unsigned long st 
		radix__flush_tlb_pwc_range_psize(vma->vm_mm, start, end, psize);

	else

		radix__flush_tlb_range_psize(vma->vm_mm, start, end, psize);

	mmu_notifier_invalidate_range(vma->vm_mm, start, end);

	mmu_notifier_arch_invalidate_secondary_tlbs(vma->vm_mm, start, end);

}



void radix__huge_ptep_modify_prot_commit(struct vm_area_struct *vma,

arch/powerpc/mm/book3s64/radix_tlb.c

+4 −4
Original line number Diff line number Diff line
@@ -987,7 +987,7 @@ void radix__flush_tlb_mm(struct mm_struct *mm) 
		}

	}

	preempt_enable();

	mmu_notifier_invalidate_range(mm, 0, -1UL);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);

}

EXPORT_SYMBOL(radix__flush_tlb_mm);
@@ -1021,7 +1021,7 @@ static void __flush_all_mm(struct mm_struct *mm, bool fullmm) 
			_tlbiel_pid_multicast(mm, pid, RIC_FLUSH_ALL);

	}

	preempt_enable();

	mmu_notifier_invalidate_range(mm, 0, -1UL);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);

}



void radix__flush_all_mm(struct mm_struct *mm)
@@ -1230,7 +1230,7 @@ static inline void __radix__flush_tlb_range(struct mm_struct *mm, 
	}

out:

	preempt_enable();

	mmu_notifier_invalidate_range(mm, start, end);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, start, end);

}



void radix__flush_tlb_range(struct vm_area_struct *vma, unsigned long start,
@@ -1395,7 +1395,7 @@ static void __radix__flush_tlb_range_psize(struct mm_struct *mm, 
	}

out:

	preempt_enable();

	mmu_notifier_invalidate_range(mm, start, end);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, start, end);

}



void radix__flush_tlb_range_psize(struct mm_struct *mm, unsigned long start,

arch/x86/include/asm/tlbflush.h

+1 −1
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *b 
{

	inc_mm_tlb_gen(mm);

	cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm));

	mmu_notifier_invalidate_range(mm, 0, -1UL);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);

}



static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm)

arch/x86/mm/tlb.c

+1 −1
Original line number Diff line number Diff line
@@ -1037,7 +1037,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, 


	put_flush_tlb_info();

	put_cpu();

	mmu_notifier_invalidate_range(mm, start, end);

	mmu_notifier_arch_invalidate_secondary_tlbs(mm, start, end);

}