Skip to content
Commit 1ad273d6 authored by Peter Hutterer's avatar Peter Hutterer Committed by Jiri Kosina
Browse files

HID: input: do not run GET_REPORT unless there's a Resolution Multiplier



hid-multitouch currently runs GET_REPORT for Contact Max and again to
retrieve the Win8 blob. If both are within the same report, the
Resolution Multiplier code calls GET_FEATURE again and this time,
possibly due to timing, it causes the ILITEK-TP device interpret the
GET_FEATURE as an instruction to change the mode and effectively stop
the device from functioning as expected.

Notably: the device doesn't even have a Resolution Multiplier so it
shouldn't be affected by any of this at all.

Fix this by making sure we only execute GET_REPORT if there is
a Resolution Multiplier in the respective report. Where the
HID_QUIRK_NO_INIT_REPORTS field is set we just bail out immediately. This
shouldn't be triggered by any real device anyway.

Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
Tested-by: default avatarWen He <wen.he_1@nxp.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 8e9ddbde
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment