Commit 1aa8f9da authored by Anirudh Rayabharam's avatar Anirudh Rayabharam Committed by Greg Kroah-Hartman
Browse files

staging: wimax/i2400m: fix some byte order issues found by sparse 



Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare()
function:

wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:195:34: warning: invalid assignment: +=
wimax/i2400m/fw.c:195:34:    left side has type unsigned int
wimax/i2400m/fw.c:195:34:    right side has type restricted __le32
wimax/i2400m/fw.c:196:32: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:196:47: warning: restricted __le32 degrades to integer
wimax/i2400m/fw.c:196:66: warning: restricted __le32 degrades to integer

Signed-off-by: default avatarAnirudh Rayabharam <mail@anirudhrb.com>
Link: https://lore.kernel.org/r/20210212153843.8554-1-mail@anirudhrb.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40311960

drivers/staging/wimax/i2400m/fw.c

+10 −5
Original line number Diff line number Diff line
@@ -189,12 +189,17 @@ void i2400m_bm_cmd_prepare(struct i2400m_bootrom_header *cmd) 
{

	if (i2400m_brh_get_use_checksum(cmd)) {

		int i;

		u32 checksum = 0;

		__le32 checksum = 0;

		const u32 *checksum_ptr = (void *) cmd->payload;

		for (i = 0; i < cmd->data_size / 4; i++)

			checksum += cpu_to_le32(*checksum_ptr++);

		checksum += cmd->command + cmd->target_addr + cmd->data_size;

		cmd->block_checksum = cpu_to_le32(checksum);



		for (i = 0; i < le32_to_cpu(cmd->data_size) / 4; i++)

			le32_add_cpu(&checksum, *checksum_ptr++);



		le32_add_cpu(&checksum, le32_to_cpu(cmd->command));

		le32_add_cpu(&checksum, le32_to_cpu(cmd->target_addr));

		le32_add_cpu(&checksum, le32_to_cpu(cmd->data_size));



		cmd->block_checksum = checksum;

	}

}

EXPORT_SYMBOL_GPL(i2400m_bm_cmd_prepare);