Commit 1a87e641 authored by Rob Herring's avatar Rob Herring Committed by David S. Miller
Browse files

net: Use of_property_read_bool() for boolean properties 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to of_property_read_bool().

Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for net/can
Acked-by: default avatarKalle Valo <kvalo@kernel.org>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Reviewed-by: default avatarWei Fang <wei.fang@nxp.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65d63e82

drivers/net/can/cc770/cc770_platform.c

+6 −6
Original line number Diff line number Diff line
@@ -93,20 +93,20 @@ static int cc770_get_of_node_data(struct platform_device *pdev, 
	if (priv->can.clock.freq > 8000000)

		priv->cpu_interface |= CPUIF_DMC;



	if (of_get_property(np, "bosch,divide-memory-clock", NULL))

	if (of_property_read_bool(np, "bosch,divide-memory-clock"))

		priv->cpu_interface |= CPUIF_DMC;

	if (of_get_property(np, "bosch,iso-low-speed-mux", NULL))

	if (of_property_read_bool(np, "bosch,iso-low-speed-mux"))

		priv->cpu_interface |= CPUIF_MUX;



	if (!of_get_property(np, "bosch,no-comperator-bypass", NULL))

		priv->bus_config |= BUSCFG_CBY;

	if (of_get_property(np, "bosch,disconnect-rx0-input", NULL))

	if (of_property_read_bool(np, "bosch,disconnect-rx0-input"))

		priv->bus_config |= BUSCFG_DR0;

	if (of_get_property(np, "bosch,disconnect-rx1-input", NULL))

	if (of_property_read_bool(np, "bosch,disconnect-rx1-input"))

		priv->bus_config |= BUSCFG_DR1;

	if (of_get_property(np, "bosch,disconnect-tx1-output", NULL))

	if (of_property_read_bool(np, "bosch,disconnect-tx1-output"))

		priv->bus_config |= BUSCFG_DT1;

	if (of_get_property(np, "bosch,polarity-dominant", NULL))

	if (of_property_read_bool(np, "bosch,polarity-dominant"))

		priv->bus_config |= BUSCFG_POL;



	prop = of_get_property(np, "bosch,clock-out-frequency", &prop_size);

drivers/net/ethernet/cadence/macb_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4990,7 +4990,7 @@ static int macb_probe(struct platform_device *pdev) 
		bp->jumbo_max_len = macb_config->jumbo_max_len;



	bp->wol = 0;

	if (of_get_property(np, "magic-packet", NULL))

	if (of_property_read_bool(np, "magic-packet"))

		bp->wol |= MACB_WOL_HAS_MAGIC_PACKET;

	device_set_wakeup_capable(&pdev->dev, bp->wol & MACB_WOL_HAS_MAGIC_PACKET);

drivers/net/ethernet/davicom/dm9000.c

+2 −2
Original line number Diff line number Diff line
@@ -1393,9 +1393,9 @@ static struct dm9000_plat_data *dm9000_parse_dt(struct device *dev) 
	if (!pdata)

		return ERR_PTR(-ENOMEM);



	if (of_find_property(np, "davicom,ext-phy", NULL))

	if (of_property_read_bool(np, "davicom,ext-phy"))

		pdata->flags |= DM9000_PLATF_EXT_PHY;

	if (of_find_property(np, "davicom,no-eeprom", NULL))

	if (of_property_read_bool(np, "davicom,no-eeprom"))

		pdata->flags |= DM9000_PLATF_NO_EEPROM;



	ret = of_get_mac_address(np, pdata->dev_addr);

drivers/net/ethernet/freescale/fec_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4251,7 +4251,7 @@ fec_probe(struct platform_device *pdev) 
	if (ret)

		goto failed_ipc_init;



	if (of_get_property(np, "fsl,magic-packet", NULL))

	if (of_property_read_bool(np, "fsl,magic-packet"))

		fep->wol_flag |= FEC_WOL_HAS_MAGIC_PACKET;



	ret = fec_enet_init_stop_mode(fep, np);

drivers/net/ethernet/freescale/fec_mpc52xx.c

+1 −1
Original line number Diff line number Diff line
@@ -937,7 +937,7 @@ static int mpc52xx_fec_probe(struct platform_device *op) 
	priv->phy_node = of_parse_phandle(np, "phy-handle", 0);



	/* the 7-wire property means don't use MII mode */

	if (of_find_property(np, "fsl,7-wire-mode", NULL)) {

	if (of_property_read_bool(np, "fsl,7-wire-mode")) {

		priv->seven_wire_mode = 1;

		dev_info(&ndev->dev, "using 7-wire PHY mode\n");

	}