Commit 1a85b350 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

usb: typec: intel_pmc_mux: Put fwnode in error case during ->probe() 



device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 6701adfa ("usb: typec: driver for Intel PMC mux control")
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210607205007.71458-1-andy.shevchenko@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5ab14ab1

drivers/usb/typec/mux/intel_pmc_mux.c

+3 −1
Original line number Diff line number Diff line
@@ -636,9 +636,11 @@ static int pmc_usb_probe(struct platform_device *pdev) 
			break;



		ret = pmc_usb_register_port(pmc, i, fwnode);

		if (ret)

		if (ret) {

			fwnode_handle_put(fwnode);

			goto err_remove_ports;

		}

	}



	platform_set_drvdata(pdev, pmc);