Commit 1a7edd04 authored Apr 25, 2023 by Keoseong Park Committed by Martin K. Petersen May 08, 2023

scsi: ufs: core: Fix I/O hang that occurs when BKOPS fails in W-LUN suspend



Even when urgent BKOPS fails, the consumer will get stuck in runtime
suspend status. Like commit 1a5665fc ("scsi: ufs: core: WLUN suspend
SSU/enter hibern8 fail recovery"), trigger the error handler and return
-EBUSY to break the suspend.

Fixes: b294ff3e ("scsi: ufs: core: Enable power management for wlun")
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Link: https://lore.kernel.org/r/20230425031721epcms2p5d4de65616478c967d466626e20c42a3a@epcms2p5


Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ac9a7868

drivers/ufs/core/ufshcd.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -9459,8 +9459,16 @@ static int __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
		* that performance might be impacted.
		*/
		ret = ufshcd_urgent_bkops(hba);
		if (ret)
		if (ret) {
		/*
		* If return err in suspend flow, IO will hang.
		* Trigger error handler and break suspend for
		* error recovery.
		*/
		ufshcd_force_error_recovery(hba);
		ret = -EBUSY;
		goto enable_scaling;
		}
		} else {
		/* make sure that auto bkops is disabled */
		ufshcd_disable_auto_bkops(hba);