Commit 1a721de8 authored by Li Lingfeng's avatar Li Lingfeng Committed by Jens Axboe
Browse files

block: don't add or resize partition on the disk with GENHD_FL_NO_PART 



Commit a33df75c ("block: use an xarray for disk->part_tbl") remove
disk_expand_part_tbl() in add_partition(), which means all kinds of
devices will support extended dynamic `dev_t`.
However, some devices with GENHD_FL_NO_PART are not expected to add or
resize partition.
Fix this by adding check of GENHD_FL_NO_PART before add or resize
partition.

Fixes: a33df75c ("block: use an xarray for disk->part_tbl")
Signed-off-by: default avatarLi Lingfeng <lilingfeng3@huawei.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230831075900.1725842-1-lilingfeng@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 0d997f1d

block/ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -20,6 +20,8 @@ static int blkpg_do_ioctl(struct block_device *bdev, 
	struct blkpg_partition p;

	long long start, length;



	if (disk->flags & GENHD_FL_NO_PART)

		return -EINVAL;

	if (!capable(CAP_SYS_ADMIN))

		return -EACCES;

	if (copy_from_user(&p, upart, sizeof(struct blkpg_partition)))