Commit 1a62ffca authored by Emeel Hakim's avatar Emeel Hakim Committed by Saeed Mahameed
Browse files

net/mlx5e: Remove redundant macsec code 



Currently macsec_fs_tx_create uses memset to set
two parameters to zeros when they are already
initialized to zeros.

Don't pass macsec_ctx to mlx5e_macsec_fs_add_rule
since it's not used.

Signed-off-by: default avatarEmeel Hakim <ehakim@nvidia.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarRaed Salem <raeds@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 35c8de16

drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c

+1 −4
Original line number Diff line number Diff line
@@ -292,8 +292,6 @@ static int macsec_fs_tx_create(struct mlx5e_macsec_fs *macsec_fs) 
	}



	/* Tx crypto table MKE rule - MKE packets shouldn't be offloaded */

	memset(&flow_act, 0, sizeof(flow_act));

	memset(spec, 0, sizeof(*spec));

	spec->match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;



	MLX5_SET_TO_ONES(fte_match_param, spec->match_criteria, outer_headers.ethertype);
@@ -1109,7 +1107,6 @@ static void macsec_fs_rx_setup_fte(struct mlx5_flow_spec *spec, 


static union mlx5e_macsec_rule *

macsec_fs_rx_add_rule(struct mlx5e_macsec_fs *macsec_fs,

		      const struct macsec_context *macsec_ctx,

		      struct mlx5_macsec_rule_attrs *attrs,

		      u32 fs_id)

{
@@ -1334,7 +1331,7 @@ mlx5e_macsec_fs_add_rule(struct mlx5e_macsec_fs *macsec_fs, 
{

	return (attrs->action == MLX5_ACCEL_MACSEC_ACTION_ENCRYPT) ?

		macsec_fs_tx_add_rule(macsec_fs, macsec_ctx, attrs, sa_fs_id) :

		macsec_fs_rx_add_rule(macsec_fs, macsec_ctx, attrs, *sa_fs_id);

		macsec_fs_rx_add_rule(macsec_fs, attrs, *sa_fs_id);

}



void mlx5e_macsec_fs_del_rule(struct mlx5e_macsec_fs *macsec_fs,