Commit 1a5db707 authored by Gerald Schaefer's avatar Gerald Schaefer Committed by Vasily Gorbik
Browse files

s390/block/dcssblk: add error handling support for add_disk() 



We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Signed-off-by: default avatarGerald Schaefer <gerald.schaefer@linux.ibm.com>
Link: https://lore.kernel.org/r/20210927220232.1071926-6-mcgrof@kernel.org


Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 11dfe199

drivers/s390/block/dcssblk.c

+7 −1
Original line number Diff line number Diff line
@@ -696,7 +696,9 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char 
	}



	get_device(&dev_info->dev);

	device_add_disk(&dev_info->dev, dev_info->gd, NULL);

	rc = device_add_disk(&dev_info->dev, dev_info->gd, NULL);

	if (rc)

		goto out_dax;



	switch (dev_info->segment_type) {

		case SEG_TYPE_SR:
@@ -712,6 +714,10 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char 
	rc = count;

	goto out;



out_dax:

	put_device(&dev_info->dev);

	kill_dax(dev_info->dax_dev);

	put_dax(dev_info->dax_dev);

put_dev:

	list_del(&dev_info->lh);

	blk_cleanup_disk(dev_info->gd);