Commit 1a59c9c5 authored by Wei Yongjun's avatar Wei Yongjun Committed by Jakub Kicinski
Browse files

net: mscc: ocelot: fix missing unlock on error in ocelot_hwstamp_set() 



Add the missing mutex_unlock before return from function
ocelot_hwstamp_set() in the ocelot_setup_ptp_traps() error
handling case.

Fixes: 96ca08c0 ("net: mscc: ocelot: set up traps for PTP packets")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20211129151652.1165433-1-weiyongjun1@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5fdc2333

drivers/net/ethernet/mscc/ocelot.c

+3 −1
Original line number Diff line number Diff line
@@ -1563,8 +1563,10 @@ int ocelot_hwstamp_set(struct ocelot *ocelot, int port, struct ifreq *ifr) 
	}



	err = ocelot_setup_ptp_traps(ocelot, port, l2, l4);

	if (err)

	if (err) {

		mutex_unlock(&ocelot->ptp_lock);

		return err;

	}



	if (l2 && l4)

		cfg.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;