Commit 1a550486 authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by Saeed Mahameed
Browse files

net/mlx5e: Remove the duplicating check for striding RQ when enabling LRO 



LRO requires striding RQ and checks that it's enabled at two places:
mlx5e_fix_features and set_feature_lro. This commit keeps only one check
at mlx5e_fix_features and removes the duplicating one in
set_feature_lro.

Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 1c31cb92

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+0 −6
Original line number Diff line number Diff line
@@ -3595,12 +3595,6 @@ static int set_feature_lro(struct net_device *netdev, bool enable) 
	mutex_lock(&priv->state_lock);



	cur_params = &priv->channels.params;

	if (enable && !MLX5E_GET_PFLAG(cur_params, MLX5E_PFLAG_RX_STRIDING_RQ)) {

		netdev_warn(netdev, "can't set LRO with legacy RQ\n");

		err = -EINVAL;

		goto out;

	}



	new_params = *cur_params;



	if (enable)