Commit 1a50cf9a authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix incorrect access of RCU-protected xdp_prog 



rq->xdp_prog is RCU-protected and should be accessed only with
rcu_access_pointer for the NULL check in mlx5e_poll_rx_cq.

rq->xdp_prog may change on the fly only from one non-NULL value to
another non-NULL value, so the checks in mlx5e_xdp_handle and
mlx5e_poll_rx_cq will have the same result during one NAPI cycle,
meaning that no additional synchronization is needed.

Fixes: fe45386a ("net/mlx5e: Use RCU to protect rq->xdp_prog")
Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent c5eb51ad

drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -1584,7 +1584,7 @@ int mlx5e_poll_rx_cq(struct mlx5e_cq *cq, int budget) 
	} while ((++work_done < budget) && (cqe = mlx5_cqwq_get_cqe(cqwq)));



out:

	if (rq->xdp_prog)

	if (rcu_access_pointer(rq->xdp_prog))

		mlx5e_xdp_rx_poll_complete(rq);



	mlx5_cqwq_update_db_record(cqwq);