Commit 1a460c36 authored by Tom Rix's avatar Tom Rix Committed by Greg Kroah-Hartman
Browse files

tty: nozomi: remove unneeded break 



A break is not needed if it is preceded by a return

Add explicit fallthrough

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20201019175732.3289-1-trix@redhat.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 974e454d

drivers/tty/nozomi.c

+1 −4
Original line number Diff line number Diff line
@@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start, 
		buf16 = (u16 *) buf;

		*buf16 = __le16_to_cpu(readw(ptr));

		goto out;

		break;

	case 4:	/* 4 bytes */

		*(buf) = __le32_to_cpu(readl(ptr));

		goto out;

		break;

	}



	while (i < size_bytes) {
@@ -460,15 +458,14 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf, 
		buf16 = (const u16 *)buf;

		writew(__cpu_to_le16(*buf16), ptr);

		return 2;

		break;

	case 1: /*

		 * also needs to write 4 bytes in this case

		 * so falling through..

		 */

		fallthrough;

	case 4: /* 4 bytes */

		writel(__cpu_to_le32(*buf), ptr);

		return 4;

		break;

	}



	while (i < size_bytes) {