Commit 1a42156f authored by Lijun Pan's avatar Lijun Pan Committed by David S. Miller
Browse files

ibmvnic: substitute mb() with dma_wmb() for send_*crq* functions 



The CRQ and subCRQ descriptors are DMA mapped, so dma_wmb(),
though weaker, is good enough to protect the data structures.

Signed-off-by: default avatarLijun Pan <ljp@linux.ibm.com>
Acked-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1c7d45e7

drivers/net/ethernet/ibm/ibmvnic.c

+2 −2
Original line number Diff line number Diff line
@@ -3599,7 +3599,7 @@ static int send_subcrq_indirect(struct ibmvnic_adapter *adapter, 
	int rc;



	/* Make sure the hypervisor sees the complete request */

	mb();

	dma_wmb();

	rc = plpar_hcall_norets(H_SEND_SUB_CRQ_INDIRECT, ua,

				cpu_to_be64(remote_handle),

				ioba, num_entries);
@@ -3629,7 +3629,7 @@ static int ibmvnic_send_crq(struct ibmvnic_adapter *adapter, 
	}



	/* Make sure the hypervisor sees the complete request */

	mb();

	dma_wmb();



	rc = plpar_hcall_norets(H_SEND_CRQ, ua,

				cpu_to_be64(u64_crq[0]),