Commit 1a20719e authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Remove superfluous sts_entry_* casts 



The C language supports implicit casting of void pointers to non-void
pointers. Remove explicit sts_entry_* casts that are not necessary.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5ec9f904

drivers/scsi/qla2xxx/qla_isr.c

+5 −10
Original line number Diff line number Diff line
@@ -1513,7 +1513,7 @@ qla2x00_ct_entry(scsi_qla_host_t *vha, struct req_que *req, 
		    if (comp_status == CS_DATA_UNDERRUN) {

			    res = DID_OK << 16;

			    bsg_reply->reply_payload_rcv_len =

				le16_to_cpu(((sts_entry_t *)pkt)->rsp_info_len);

				le16_to_cpu(pkt->rsp_info_len);



			    ql_log(ql_log_warn, vha, 0x5048,

				"CT pass-through-%s error comp_status=0x%x total_byte=0x%x.\n",
@@ -2256,11 +2256,8 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt, 
	struct bsg_job *bsg_job = NULL;

	struct fc_bsg_request *bsg_request;

	struct fc_bsg_reply *bsg_reply;

	sts_entry_t *sts;

	struct sts_entry_24xx *sts24;



	sts = (sts_entry_t *) pkt;

	sts24 = (struct sts_entry_24xx *) pkt;

	sts_entry_t *sts = pkt;

	struct sts_entry_24xx *sts24 = pkt;



	/* Validate handle. */

	if (index >= req->num_outstanding_cmds) {
@@ -2406,8 +2403,8 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) 
	srb_t		*sp;

	fc_port_t	*fcport;

	struct scsi_cmnd *cp;

	sts_entry_t *sts;

	struct sts_entry_24xx *sts24;

	sts_entry_t *sts = pkt;

	struct sts_entry_24xx *sts24 = pkt;

	uint16_t	comp_status;

	uint16_t	scsi_status;

	uint16_t	ox_id;
@@ -2425,8 +2422,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) 
	uint16_t state_flags = 0;

	uint16_t retry_delay = 0;



	sts = (sts_entry_t *) pkt;

	sts24 = (struct sts_entry_24xx *) pkt;

	if (IS_FWI2_CAPABLE(ha)) {

		comp_status = le16_to_cpu(sts24->comp_status);

		scsi_status = le16_to_cpu(sts24->scsi_status) & SS_MASK;