Commit 1a048301 authored by Stefan Binding's avatar Stefan Binding Committed by Takashi Iwai
Browse files

ALSA: hda/cs8409: Prevent pops and clicks during suspend 



Some of the register values set for type detection cause pops during suspend,
ensure these are cleaned up after type detection completes, as well
ensuring that these are cleared when we suspend.

Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Signed-off-by: default avatarVitaly Rodionov <vitalyr@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210812183433.6330-1-vitalyr@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0c4aa677

sound/pci/hda/patch_cs8409.c

+6 −0
Original line number Diff line number Diff line
@@ -708,6 +708,10 @@ static int cs42l42_jack_unsol_event(struct sub_codec *cs42l42) 
				cs42l42->mic_jack_in = 1;

			}

		}

		/* Configure the HSDET mode. */

		cs8409_i2c_write(cs42l42, 0x1120, 0x80);

		/* Enable the HPOUT ground clamp and configure the HP pull-down */

		cs8409_i2c_write(cs42l42, 0x1F06, 0x02);

		/* Re-Enable Tip Sense Interrupt */

		cs8409_i2c_write(cs42l42, 0x1320, 0xF3);

	} else {
@@ -756,6 +760,8 @@ static void cs42l42_suspend(struct sub_codec *cs42l42) 
	unsigned int gpio_data;

	int reg_cdc_status = 0;

	const struct cs8409_i2c_param cs42l42_pwr_down_seq[] = {

		{ 0x1F06, 0x02 },

		{ 0x1129, 0x00 },

		{ 0x2301, 0x3F },

		{ 0x2302, 0x3F },

		{ 0x2303, 0x3F },