Commit 19e9bfa0 authored by Vlad Buslov's avatar Vlad Buslov Committed by Saeed Mahameed
Browse files

net/mlx5: Bridge, add offload infrastructure 



Create new files bridge.{c|h} in en/rep directory that implement bridge
interaction with representor netdevices and handle required
events/notifications, bridge.{c|h} in esw directory that implement all
necessary eswitch offloading infrastructure and works on vport/eswitch
level. Provide new kconfig MLX5_BRIDGE which is automatically selected when
both kernel bridge and mlx5 eswitch configs are enabled.

Provide basic infrastructure for bridge offloads:

- struct mlx5_esw_bridge_offloads - per-eswitch bridge offload structure
that encapsulates generic bridge-offloads data (notifier blocks, ingress
flow table/group, etc.) that is created/deleted on enable/disable eswitch
offloads.

- struct mlx5_esw_bridge - per-bridge structure that encapsulates
per-bridge data (reference counter, FDB, egress flow table/group, etc.)
that is created when first eswitch represetor is attached to new bridge and
deleted when last representor is removed from the bridge as a result of
NETDEV_CHANGEUPPER event.

The bridge tables are created with new priority FDB_BR_OFFLOAD in FDB
namespace. The new priority is between tc-miss and slow path priorities.
Priority consist of two levels: the ingress table that is global per
eswitch and matches incoming packets by src_mac/vid and redirects them to
next level (egress table) that is chosen according to ingress port bridge
membership and matches on dst_mac/vid in order to redirect packet to vport
according to the following diagram:

                +
                |
      +---------v----------+
      |                    |
      |   FDB_TC_OFFLOAD   |
      |                    |
      +---------+----------+
                |
                |
      +---------v----------+
      |                    |
      |   FDB_FT_OFFLOAD   |
      |                    |
      +---------+----------+
                |
                |
      +---------v----------+
      |                    |
      |    FDB_TC_MISS     |
      |                    |
      +---------+----------+
                |
+--------------------------------------+
|               |                      |
|        +------+                      |
|        |                             |
| +------v--------+   FDB_BR_OFFLOAD   |
| | INGRESS_TABLE |                    |
| +------+---+----+                    |
|        |   |      match              |
|        |   +---------+               |
|        |             |               |    +-------+
|        |     +-------v-------+ match |    |       |
|        |     | EGRESS_TABLE  +------------> vport |
|        |     +-------+-------+       |    |       |
|        |             |               |    +-------+
|        |    miss     |               |
|        +------+------+               |
|               |                      |
+--------------------------------------+
                |
                |
      +---------v----------+
      |                    |
      |   FDB_SLOW_PATH    |
      |                    |
      +---------+----------+
                |
                v

Signed-off-by: default avatarVlad Buslov <vladbu@nvidia.com>
Reviewed-by: default avatarJianbo Liu <jianbol@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 07810152

drivers/net/ethernet/mellanox/mlx5/core/Kconfig

+10 −0
Original line number Diff line number Diff line
@@ -79,6 +79,16 @@ config MLX5_ESWITCH 
	        Legacy SRIOV mode (L2 mac vlan steering based).

	        Switchdev mode (eswitch offloads).



config MLX5_BRIDGE

	bool

	depends on MLX5_ESWITCH && BRIDGE

	default y

	help

	  mlx5 ConnectX offloads support for Ethernet Bridging (BRIDGE).

	  Enable adding representors of mlx5 uplink and VF ports to Bridge and

	  offloading rules for traffic between such ports. Supports VLANs (trunk and

	  access modes).



config MLX5_CLS_ACT

	bool "MLX5 TC classifier action support"

	depends on MLX5_ESWITCH && NET_CLS_ACT

drivers/net/ethernet/mellanox/mlx5/core/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -56,6 +56,7 @@ mlx5_core-$(CONFIG_MLX5_ESWITCH) += esw/acl/helper.o \ 
				      esw/acl/ingress_lgcy.o esw/acl/ingress_ofld.o \

				      esw/devlink_port.o esw/vporttbl.o

mlx5_core-$(CONFIG_MLX5_TC_SAMPLE) += esw/sample.o

mlx5_core-$(CONFIG_MLX5_BRIDGE)    += esw/bridge.o en/rep/bridge.o



mlx5_core-$(CONFIG_MLX5_MPFS)      += lib/mpfs.o

mlx5_core-$(CONFIG_VXLAN)          += lib/vxlan.o

drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c

0 → 100644
+108 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB

/* Copyright (c) 2021 Mellanox Technologies. */



#include <linux/netdevice.h>

#include <net/netevent.h>

#include <net/switchdev.h>

#include "bridge.h"

#include "esw/bridge.h"

#include "en_rep.h"



static int mlx5_esw_bridge_port_changeupper(struct notifier_block *nb, void *ptr)

{

	struct mlx5_esw_bridge_offloads *br_offloads = container_of(nb,

								    struct mlx5_esw_bridge_offloads,

								    netdev_nb);

	struct net_device *dev = netdev_notifier_info_to_dev(ptr);

	struct netdev_notifier_changeupper_info *info = ptr;

	struct netlink_ext_ack *extack;

	struct mlx5e_rep_priv *rpriv;

	struct mlx5_eswitch *esw;

	struct mlx5_vport *vport;

	struct net_device *upper;

	struct mlx5e_priv *priv;

	u16 vport_num;



	if (!mlx5e_eswitch_rep(dev))

		return 0;



	upper = info->upper_dev;

	if (!netif_is_bridge_master(upper))

		return 0;



	esw = br_offloads->esw;

	priv = netdev_priv(dev);

	if (esw != priv->mdev->priv.eswitch)

		return 0;



	rpriv = priv->ppriv;

	vport_num = rpriv->rep->vport;

	vport = mlx5_eswitch_get_vport(esw, vport_num);

	if (IS_ERR(vport))

		return PTR_ERR(vport);



	extack = netdev_notifier_info_to_extack(&info->info);



	return info->linking ?

		mlx5_esw_bridge_vport_link(upper->ifindex, br_offloads, vport, extack) :

		mlx5_esw_bridge_vport_unlink(upper->ifindex, br_offloads, vport, extack);

}



static int mlx5_esw_bridge_switchdev_port_event(struct notifier_block *nb,

						unsigned long event, void *ptr)

{

	int err = 0;



	switch (event) {

	case NETDEV_PRECHANGEUPPER:

		break;



	case NETDEV_CHANGEUPPER:

		err = mlx5_esw_bridge_port_changeupper(nb, ptr);

		break;

	}



	return notifier_from_errno(err);

}



void mlx5e_rep_bridge_init(struct mlx5e_priv *priv)

{

	struct mlx5_esw_bridge_offloads *br_offloads;

	struct mlx5_core_dev *mdev = priv->mdev;

	struct mlx5_eswitch *esw =

		mdev->priv.eswitch;

	int err;



	rtnl_lock();

	br_offloads = mlx5_esw_bridge_init(esw);

	rtnl_unlock();

	if (IS_ERR(br_offloads)) {

		esw_warn(mdev, "Failed to init esw bridge (err=%ld)\n", PTR_ERR(br_offloads));

		return;

	}



	br_offloads->netdev_nb.notifier_call = mlx5_esw_bridge_switchdev_port_event;

	err = register_netdevice_notifier(&br_offloads->netdev_nb);

	if (err) {

		esw_warn(mdev, "Failed to register bridge offloads netdevice notifier (err=%d)\n",

			 err);

		mlx5_esw_bridge_cleanup(esw);

	}

}



void mlx5e_rep_bridge_cleanup(struct mlx5e_priv *priv)

{

	struct mlx5_esw_bridge_offloads *br_offloads;

	struct mlx5_core_dev *mdev = priv->mdev;

	struct mlx5_eswitch *esw =

		mdev->priv.eswitch;



	br_offloads = esw->br_offloads;

	if (!br_offloads)

		return;



	unregister_netdevice_notifier(&br_offloads->netdev_nb);

	rtnl_lock();

	mlx5_esw_bridge_cleanup(esw);

	rtnl_unlock();

}

drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.h

0 → 100644
+21 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */

/* Copyright (c) 2021 Mellanox Technologies. */



#ifndef __MLX5_EN_REP_BRIDGE__

#define __MLX5_EN_REP_BRIDGE__



#include "en.h"



#if IS_ENABLED(CONFIG_MLX5_BRIDGE)



void mlx5e_rep_bridge_init(struct mlx5e_priv *priv);

void mlx5e_rep_bridge_cleanup(struct mlx5e_priv *priv);



#else /* CONFIG_MLX5_BRIDGE */



static inline void mlx5e_rep_bridge_init(struct mlx5e_priv *priv) {}

static inline void mlx5e_rep_bridge_cleanup(struct mlx5e_priv *priv) {}



#endif /* CONFIG_MLX5_BRIDGE */



#endif /* __MLX5_EN_REP_BRIDGE__ */

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+3 −0
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ 
#include "en_tc.h"

#include "en/rep/tc.h"

#include "en/rep/neigh.h"

#include "en/rep/bridge.h"

#include "en/devlink.h"

#include "fs_core.h"

#include "lib/mlx5.h"
@@ -981,6 +982,7 @@ static void mlx5e_uplink_rep_enable(struct mlx5e_priv *priv) 
	mlx5e_dcbnl_initialize(priv);

	mlx5e_dcbnl_init_app(priv);

	mlx5e_rep_neigh_init(rpriv);

	mlx5e_rep_bridge_init(priv);



	netdev->wanted_features |= NETIF_F_HW_TC;
@@ -1002,6 +1004,7 @@ static void mlx5e_uplink_rep_disable(struct mlx5e_priv *priv) 
	netif_device_detach(priv->netdev);

	rtnl_unlock();



	mlx5e_rep_bridge_cleanup(priv);

	mlx5e_rep_neigh_cleanup(rpriv);

	mlx5e_dcbnl_delete_app(priv);

	mlx5_notifier_unregister(mdev, &priv->events_nb);