Commit 19a9a0ef authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm: Refuse to create zero width/height cmdline modes 



If the user specifies zero width/height cmdline mode i915 will
blow up as the fbdev path will bypass the regular fb sanity
check that would otherwise have refused to create a framebuffer
with zero width/height.

The reason I thought to try this is so that I can force a specific
depth for fbdev without actually having to hardcode the mode
on the kernel cmdline. Eg. if I pass video=0x0-8 I will get an
8bpp framebuffer at my monitor's native resolution.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190607162611.23514-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 62066d31

drivers/gpu/drm/drm_modes.c

+3 −0
Original line number Diff line number Diff line
@@ -1864,6 +1864,9 @@ drm_mode_create_from_cmdline_mode(struct drm_device *dev, 
{

	struct drm_display_mode *mode;



	if (cmd->xres == 0 || cmd->yres == 0)

		return NULL;



	if (cmd->cvt)

		mode = drm_cvt_mode(dev,

				    cmd->xres, cmd->yres,