Commit 19679394 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Miguel Ojeda
Browse files

Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK 



Revert commit cebc04ba ("add CONFIG_ENABLE_MUST_CHECK").

A lot of warn_unused_result warnings existed in 2006, but until now
they have been fixed thanks to people doing allmodconfig tests.

Our goal is to always enable __must_check where appropriate, so this
CONFIG option is no longer needed.

I see a lot of defconfig (arch/*/configs/*_defconfig) files having:

    # CONFIG_ENABLE_MUST_CHECK is not set

I did not touch them for now since it would be a big churn. If arch
maintainers want to clean them up, please go ahead.

While I was here, I also moved __must_check to compiler_attributes.h
from compiler_types.h

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Acked-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Acked-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
[Moved addition in compiler_attributes.h to keep it sorted]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent b6505459

include/linux/compiler_attributes.h

+6 −0
Original line number Diff line number Diff line
@@ -272,6 +272,12 @@ 
 */

#define __used                          __attribute__((__used__))



/*

 *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-warn_005funused_005fresult-function-attribute

 * clang: https://clang.llvm.org/docs/AttributeReference.html#nodiscard-warn-unused-result

 */

#define __must_check                    __attribute__((__warn_unused_result__))



/*

 *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-weak-function-attribute

 *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#index-weak-variable-attribute

include/linux/compiler_types.h

+0 −6
Original line number Diff line number Diff line
@@ -110,12 +110,6 @@ struct ftrace_likely_data { 
	unsigned long			constant;

};



#ifdef CONFIG_ENABLE_MUST_CHECK

#define __must_check		__attribute__((__warn_unused_result__))

#else

#define __must_check

#endif



#if defined(CC_USING_HOTPATCH)

#define notrace			__attribute__((hotpatch(0, 0)))

#elif defined(CC_USING_PATCHABLE_FUNCTION_ENTRY)

lib/Kconfig.debug

+0 −8
Original line number Diff line number Diff line
@@ -286,14 +286,6 @@ config GDB_SCRIPTS 


endif # DEBUG_INFO



config ENABLE_MUST_CHECK

	bool "Enable __must_check logic"

	default y

	help

	  Enable the __must_check logic in the kernel build.  Disable this to

	  suppress the "warning: ignoring return value of 'foo', declared with

	  attribute warn_unused_result" messages.



config FRAME_WARN

	int "Warn for stack frames larger than"

	range 0 8192

tools/testing/selftests/wireguard/qemu/debug.config

+0 −1
Original line number Diff line number Diff line 
CONFIG_LOCALVERSION="-debug"

CONFIG_ENABLE_MUST_CHECK=y

CONFIG_FRAME_POINTER=y

CONFIG_STACK_VALIDATION=y

CONFIG_DEBUG_KERNEL=y