Commit 192b722f authored by Jason Wang's avatar Jason Wang Committed by Herbert Xu
Browse files

crypto: sun8i-ss - Use kfree_sensitive 



The kfree_sensitive is a kernel API to clear sensitive information
that should not be leaked to other future users of the same memory
objects and free the memory. Its function is the same as the
combination of memzero_explicit and kfree. Thus, we can replace the
combination APIs with the single kfree_sensitive API.

Signed-off-by: default avatarJason Wang <wangborong@cdjrlc.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ec2088b6

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c

+3 −6
Original line number Diff line number Diff line
@@ -20,8 +20,7 @@ int sun8i_ss_prng_seed(struct crypto_rng *tfm, const u8 *seed, 
	struct sun8i_ss_rng_tfm_ctx *ctx = crypto_rng_ctx(tfm);



	if (ctx->seed && ctx->slen != slen) {

		memzero_explicit(ctx->seed, ctx->slen);

		kfree(ctx->seed);

		kfree_sensitive(ctx->seed);

		ctx->slen = 0;

		ctx->seed = NULL;

	}
@@ -48,8 +47,7 @@ void sun8i_ss_prng_exit(struct crypto_tfm *tfm) 
{

	struct sun8i_ss_rng_tfm_ctx *ctx = crypto_tfm_ctx(tfm);



	memzero_explicit(ctx->seed, ctx->slen);

	kfree(ctx->seed);

	kfree_sensitive(ctx->seed);

	ctx->seed = NULL;

	ctx->slen = 0;

}
@@ -167,9 +165,8 @@ int sun8i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src, 
		/* Update seed */

		memcpy(ctx->seed, d + dlen, ctx->slen);

	}

	memzero_explicit(d, todo);

err_free:

	kfree(d);

	kfree_sensitive(d);



	return err;

}