Unverified Commit 19045783 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!14358 firmware_loader: Fix possible resource leak in fw_log_firmware_info() 

Merge Pull Request from: @ci-robot 
 
PR sync from: dinglongwei <dinglongwei1@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/UYEAJ3IPD4SWBB4PE44ALQAIIA3CKN4G/ 
 
https://gitee.com/src-openeuler/kernel/issues/IBEAFY 
 
Link:https://gitee.com/openeuler/kernel/pulls/14358

 

Reviewed-by: default avatarWeilong Chen <chenweilong@huawei.com>
Signed-off-by: default avatarZhang Peng <zhangpeng362@huawei.com>
parents 512534f2 52ef2fac

drivers/base/firmware_loader/main.c

+2 −3
Original line number Diff line number Diff line
@@ -824,19 +824,18 @@ static void fw_log_firmware_info(const struct firmware *fw, const char *name, st 
	shash->tfm = alg;



	if (crypto_shash_digest(shash, fw->data, fw->size, sha256buf) < 0)

		goto out_shash;

		goto out_free;



	for (int i = 0; i < SHA256_DIGEST_SIZE; i++)

		sprintf(&outbuf[i * 2], "%02x", sha256buf[i]);

	outbuf[SHA256_BLOCK_SIZE] = 0;

	dev_dbg(device, "Loaded FW: %s, sha256: %s\n", name, outbuf);



out_shash:

	crypto_free_shash(alg);

out_free:

	kfree(shash);

	kfree(outbuf);

	kfree(sha256buf);

	crypto_free_shash(alg);

}

#else

static void fw_log_firmware_info(const struct firmware *fw, const char *name,