Commit 18e7e3e4 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Fix reporting active_{speed,width} attributes 

After commit 6d758147 ("RDMA/bnxt_re: Use auxiliary driver interface")
the active_{speed, width} attributes are reported incorrectly, This is
happening because ib_get_eth_speed() is called only once from
bnxt_re_ib_init() - Fix this issue by calling ib_get_eth_speed() from
bnxt_re_query_port().

Fixes: 6d758147 ("RDMA/bnxt_re: Use auxiliary driver interface")
Link: https://lore.kernel.org/r/20230529153525.87254-1-kheib@redhat.com


Signed-off-by: default avatarKamal Heib <kheib@redhat.com>
Acked-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent b0068342

drivers/infiniband/hw/bnxt_re/bnxt_re.h

+0 −2
Original line number Diff line number Diff line
@@ -135,8 +135,6 @@ struct bnxt_re_dev { 


	struct delayed_work		worker;

	u8				cur_prio_map;

	u16				active_speed;

	u8				active_width;



	/* FP Notification Queue (CQ & SRQ) */

	struct tasklet_struct		nq_task;

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+4 −3
Original line number Diff line number Diff line
@@ -199,6 +199,7 @@ int bnxt_re_query_port(struct ib_device *ibdev, u32 port_num, 
{

	struct bnxt_re_dev *rdev = to_bnxt_re_dev(ibdev, ibdev);

	struct bnxt_qplib_dev_attr *dev_attr = &rdev->dev_attr;

	int rc;



	memset(port_attr, 0, sizeof(*port_attr));
@@ -228,10 +229,10 @@ int bnxt_re_query_port(struct ib_device *ibdev, u32 port_num, 
	port_attr->sm_sl = 0;

	port_attr->subnet_timeout = 0;

	port_attr->init_type_reply = 0;

	port_attr->active_speed = rdev->active_speed;

	port_attr->active_width = rdev->active_width;

	rc = ib_get_eth_speed(&rdev->ibdev, port_num, &port_attr->active_speed,

			      &port_attr->active_width);



	return 0;

	return rc;

}



int bnxt_re_get_port_immutable(struct ib_device *ibdev, u32 port_num,

drivers/infiniband/hw/bnxt_re/main.c

+0 −2
Original line number Diff line number Diff line
@@ -1077,8 +1077,6 @@ static int bnxt_re_ib_init(struct bnxt_re_dev *rdev) 
		return rc;

	}

	dev_info(rdev_to_dev(rdev), "Device registered with IB successfully");

	ib_get_eth_speed(&rdev->ibdev, 1, &rdev->active_speed,

			 &rdev->active_width);

	set_bit(BNXT_RE_FLAG_ISSUE_ROCE_STATS, &rdev->flags);



	event = netif_running(rdev->netdev) && netif_carrier_ok(rdev->netdev) ?