Commit 188d070d authored by Hao Luo's avatar Hao Luo Committed by Abel Vesa
Browse files

clk: imx: clk-imx8mn: fix memory leak in imx8mn_clocks_probe 



Use devm_of_iomap() instead of of_iomap() to automatically handle
the unused ioremap region.

If any error occurs, regions allocated by kzalloc() will leak,
but using devm_kzalloc() instead will automatically free the memory
using devm_kfree().

Fixes: daeb1454 ("clk: imx: imx8mn: Switch to clk_hw based API")
Fixes: 96d6392b ("clk: imx: Add support for i.MX8MN clock driver")
Signed-off-by: default avatarHao Luo <m202171776@hust.edu.cn>
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20230411015107.2645-1-m202171776@hust.edu.cn


Signed-off-by: default avatarAbel Vesa <abel.vesa@linaro.org>
parent 6e6bb163

drivers/clk/imx/clk-imx8mn.c

+4 −4
Original line number Diff line number Diff line
@@ -323,7 +323,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev) 
	void __iomem *base;

	int ret;



	clk_hw_data = kzalloc(struct_size(clk_hw_data, hws,

	clk_hw_data = devm_kzalloc(dev, struct_size(clk_hw_data, hws,

					  IMX8MN_CLK_END), GFP_KERNEL);

	if (WARN_ON(!clk_hw_data))

		return -ENOMEM;
@@ -340,10 +340,10 @@ static int imx8mn_clocks_probe(struct platform_device *pdev) 
	hws[IMX8MN_CLK_EXT4] = imx_get_clk_hw_by_name(np, "clk_ext4");



	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop");

	base = of_iomap(np, 0);

	base = devm_of_iomap(dev, np, 0, NULL);

	of_node_put(np);

	if (WARN_ON(!base)) {

		ret = -ENOMEM;

	if (WARN_ON(IS_ERR(base))) {

		ret = PTR_ERR(base);

		goto unregister_hws;

	}