Commit 1888709d authored by Anand Jain's avatar Anand Jain Committed by David Sterba
Browse files

btrfs: remove tmp variable for list traversal in btrfs_init_dev_replace_tgtdev 



In the function btrfs_init_dev_replace_tgtdev(), the local variable
devices is used only once, we can remove it.

Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent e17125b5

fs/btrfs/dev-replace.c

+1 −3
Original line number Diff line number Diff line
@@ -224,7 +224,6 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, 
{

	struct btrfs_device *device;

	struct block_device *bdev;

	struct list_head *devices;

	struct rcu_string *name;

	u64 devid = BTRFS_DEV_REPLACE_DEVID;

	int ret = 0;
@@ -244,8 +243,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, 


	sync_blockdev(bdev);



	devices = &fs_info->fs_devices->devices;

	list_for_each_entry(device, devices, dev_list) {

	list_for_each_entry(device, &fs_info->fs_devices->devices, dev_list) {

		if (device->bdev == bdev) {

			btrfs_err(fs_info,

				  "target device is in the filesystem!");