Commit 187a580c authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: iscsi: Fix set_param() handling 

In commit 9e67600e ("scsi: iscsi: Fix race condition between login and
sync thread") we meant to add a check where before we call ->set_param() we
make sure the iscsi_cls_connection is bound. The problem is that between
versions 4 and 5 of the patch the deletion of the unchecked set_param()
call was dropped so we ended up with 2 calls. As a result we can still hit
a crash where we access the unbound connection on the first call.

This patch removes that first call.

Fixes: 9e67600e ("scsi: iscsi: Fix race condition between login and sync thread")
Link: https://lore.kernel.org/r/20211010161904.60471-1-michael.christie@oracle.com


Reviewed-by: default avatarLee Duncan <lduncan@suse.com>
Reviewed-by: default avatarLi Feng <fengli@smartx.com>
Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 50b6cb35

drivers/scsi/scsi_transport_iscsi.c

+0 −2
Original line number Diff line number Diff line
@@ -2930,8 +2930,6 @@ iscsi_set_param(struct iscsi_transport *transport, struct iscsi_uevent *ev) 
			session->recovery_tmo = value;

		break;

	default:

		err = transport->set_param(conn, ev->u.set_param.param,

					   data, ev->u.set_param.len);

		if ((conn->state == ISCSI_CONN_BOUND) ||

			(conn->state == ISCSI_CONN_UP)) {

			err = transport->set_param(conn, ev->u.set_param.param,