Commit 1856628b authored by Po-Hsu Lin's avatar Po-Hsu Lin Committed by David S. Miller
Browse files

selftests: net: return non-zero for failures reported in arp_ndisc_evict_nocarrier 



Return non-zero return value if there is any failure reported in this
script during the test. Otherwise it can only reflect the status of
the last command.

Fixes: f86ca07e ("selftests: net: add arp_ndisc_evict_nocarrier")
Signed-off-by: default avatarPo-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9c4d7f45

tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh

+9 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ readonly V4_ADDR1=10.0.10.2 
readonly V6_ADDR0=2001:db8:91::1

readonly V6_ADDR1=2001:db8:91::2

nsid=100

ret=0



cleanup_v6()

{
@@ -61,7 +62,7 @@ setup_v6() { 
    if [ $? -ne 0 ]; then

        cleanup_v6

        echo "failed"

        exit

        exit 1

    fi



    # Set veth2 down, which will put veth1 in NOCARRIER state
@@ -88,7 +89,7 @@ setup_v4() { 
    if [ $? -ne 0 ]; then

        cleanup_v4

        echo "failed"

        exit

        exit 1

    fi



    # Set veth1 down, which will put veth0 in NOCARRIER state
@@ -115,6 +116,7 @@ run_arp_evict_nocarrier_enabled() { 


    if [ $? -eq 0 ];then

        echo "failed"

        ret=1

    else

        echo "ok"

    fi
@@ -134,6 +136,7 @@ run_arp_evict_nocarrier_disabled() { 
        echo "ok"

    else

        echo "failed"

        ret=1

    fi



    cleanup_v4
@@ -164,6 +167,7 @@ run_ndisc_evict_nocarrier_enabled() { 


    if [ $? -eq 0 ];then

        echo "failed"

        ret=1

    else

        echo "ok"

    fi
@@ -182,6 +186,7 @@ run_ndisc_evict_nocarrier_disabled() { 
        echo "ok"

    else

        echo "failed"

        ret=1

    fi



    cleanup_v6
@@ -198,6 +203,7 @@ run_ndisc_evict_nocarrier_disabled_all() { 
        echo "ok"

    else

        echo "failed"

        ret=1

    fi



    cleanup_v6
@@ -218,3 +224,4 @@ if [ "$(id -u)" -ne 0 ];then 
fi



run_all_tests

exit $ret