Unverified Commit 1849a150 authored by Sascha Hauer's avatar Sascha Hauer Committed by Mark Brown
Browse files

ASoC: fsl_asrc_dma: fully initialize structs 



The driver uses two statically ininitialized struct dma_slave_config,
but only one of them is initialized to zero. Initialize config_be to
zero as well to make sure that no fields are filled with random values.
Let the compiler do this instead of explicitly calling memset() which
makes it easier to read.

Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarShengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1663928147-10106-1-git-send-email-shengjiu.wang@nxp.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 08fc2a74

sound/soc/fsl/fsl_asrc_dma.c

+1 −2
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static int fsl_asrc_dma_hw_params(struct snd_soc_component *component, 
	struct dma_chan *tmp_chan = NULL, *be_chan = NULL;

	struct snd_soc_component *component_be = NULL;

	struct fsl_asrc *asrc = pair->asrc;

	struct dma_slave_config config_fe, config_be;

	struct dma_slave_config config_fe = {}, config_be = {};

	struct sdma_peripheral_config audio_config;

	enum asrc_pair_index index = pair->index;

	struct device *dev = component->dev;
@@ -183,7 +183,6 @@ static int fsl_asrc_dma_hw_params(struct snd_soc_component *component, 
		return -EINVAL;

	}



	memset(&config_fe, 0, sizeof(config_fe));

	ret = snd_dmaengine_pcm_prepare_slave_config(substream, params, &config_fe);

	if (ret) {

		dev_err(dev, "failed to prepare DMA config for Front-End\n");