Commit 1846a7fa authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

tools/memory-model: Make read_foo_diagnostic() more clearly diagnostic 



The current definition of read_foo_diagnostic() in the "Lock Protection
With Lockless Diagnostic Access" section returns a value, which could
be use for any purpose.  This could mislead people into incorrectly
using data_race() in cases where READ_ONCE() is required.  This commit
therefore makes read_foo_diagnostic() simply print the value read.

Reported-by: default avatarManfred Spraul <manfred@colorfullife.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 2734d6c1

tools/memory-model/Documentation/access-marking.txt

+2 −2
Original line number Diff line number Diff line
@@ -259,9 +259,9 @@ diagnostic purposes. The code might look as follows: 
		return ret;

	}



	int read_foo_diagnostic(void)

	void read_foo_diagnostic(void)

	{

		return data_race(foo);

		pr_info("Current value of foo: %d\n", data_race(foo));

	}



The reader-writer lock prevents the compiler from introducing concurrency