Commit 180b10bd authored by Daniel Mack's avatar Daniel Mack Committed by Bartosz Golaszewski
Browse files

gpio: zynq: restore zynq_gpio_irq_reqres/zynq_gpio_irq_relres callbacks 



Commit f5691439 ("gpio: zynq: fix zynqmp_gpio not an immutable chip
warning") ditched the open-coded resource allocation handlers in favor
of the generic ones. These generic handlers don't maintain the PM
runtime anymore, which causes a regression in that level IRQs are no
longer reported.

Restore the original handlers to fix this.

Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Fixes: f5691439 ("gpio: zynq: fix zynqmp_gpio not an immutable chip warning")
Cc: stable@kernel.org
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 65d6e954

drivers/gpio/gpio-zynq.c

+24 −2
Original line number Diff line number Diff line
@@ -575,6 +575,26 @@ static int zynq_gpio_set_wake(struct irq_data *data, unsigned int on) 
	return 0;

}



static int zynq_gpio_irq_reqres(struct irq_data *d)

{

	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);

	int ret;



	ret = pm_runtime_resume_and_get(chip->parent);

	if (ret < 0)

		return ret;



	return gpiochip_reqres_irq(chip, d->hwirq);

}



static void zynq_gpio_irq_relres(struct irq_data *d)

{

	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);



	gpiochip_relres_irq(chip, d->hwirq);

	pm_runtime_put(chip->parent);

}



/* irq chip descriptor */

static const struct irq_chip zynq_gpio_level_irqchip = {

	.name		= DRIVER_NAME,
@@ -584,9 +604,10 @@ static const struct irq_chip zynq_gpio_level_irqchip = { 
	.irq_unmask	= zynq_gpio_irq_unmask,

	.irq_set_type	= zynq_gpio_set_irq_type,

	.irq_set_wake	= zynq_gpio_set_wake,

	.irq_request_resources = zynq_gpio_irq_reqres,

	.irq_release_resources = zynq_gpio_irq_relres,

	.flags		= IRQCHIP_EOI_THREADED | IRQCHIP_EOI_IF_HANDLED |

			  IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,

	GPIOCHIP_IRQ_RESOURCE_HELPERS,

};



static const struct irq_chip zynq_gpio_edge_irqchip = {
@@ -597,8 +618,9 @@ static const struct irq_chip zynq_gpio_edge_irqchip = { 
	.irq_unmask	= zynq_gpio_irq_unmask,

	.irq_set_type	= zynq_gpio_set_irq_type,

	.irq_set_wake	= zynq_gpio_set_wake,

	.irq_request_resources = zynq_gpio_irq_reqres,

	.irq_release_resources = zynq_gpio_irq_relres,

	.flags		= IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,

	GPIOCHIP_IRQ_RESOURCE_HELPERS,

};



static void zynq_gpio_handle_bank_irq(struct zynq_gpio *gpio,