Commit 17e83549 authored by Liwei Song's avatar Liwei Song Committed by Wolfram Sang
Browse files

i2c: ismt: fix wrong device address when unmap the data buffer 

Fix the following kernel bug:

kernel BUG at drivers/iommu/intel-iommu.c:3260!
invalid opcode: 0000 [#5] PREEMPT SMP
Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB0.X64.0013.D39.1608311820 08/31/2016
task: ffff880175389950 ti: ffff880176bec000 task.ti: ffff880176bec000
RIP: 0010:[<ffffffff8150a83b>]  [<ffffffff8150a83b>] intel_unmap+0x25b/0x260
RSP: 0018:ffff880176bef5e8  EFLAGS: 00010296
RAX: 0000000000000024 RBX: ffff8800773c7c88 RCX: 000000000000ce04
RDX: 0000000080000000 RSI: 0000000000000000 RDI: 0000000000000009
RBP: ffff880176bef638 R08: 0000000000000010 R09: 0000000000000004
R10: ffff880175389c78 R11: 0000000000000a4f R12: ffff8800773c7868
R13: 00000000ffffac88 R14: ffff8800773c7818 R15: 0000000000000001
FS:  00007fef21258700(0000) GS:ffff88017b5c0000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000066d6d8 CR3: 000000007118c000 CR4: 00000000003406e0
Stack:
 00000000ffffac88 fffffff...
parent 91633503

drivers/i2c/busses/i2c-ismt.c

+1 −1
Original line number Diff line number Diff line
@@ -584,7 +584,7 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr, 


	/* unmap the data buffer */

	if (dma_size != 0)

		dma_unmap_single(&adap->dev, dma_addr, dma_size, dma_direction);

		dma_unmap_single(dev, dma_addr, dma_size, dma_direction);



	if (unlikely(!time_left)) {

		dev_err(dev, "completion wait timed out\n");