Commit 17c0e6d1 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_qdisc: Drop one argument from check_params callback 



The mlxsw_sp_qdisc argument is not used in any of the actual callbacks.
Drop it.

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 790aad0e

drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c

+1 −7
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ struct mlxsw_sp_qdisc; 
struct mlxsw_sp_qdisc_ops {

	enum mlxsw_sp_qdisc_type type;

	int (*check_params)(struct mlxsw_sp_port *mlxsw_sp_port,

			    struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

			    void *params);

	int (*replace)(struct mlxsw_sp_port *mlxsw_sp_port, u32 handle,

		       struct mlxsw_sp_qdisc *mlxsw_sp_qdisc, void *params);
@@ -198,7 +197,7 @@ mlxsw_sp_qdisc_replace(struct mlxsw_sp_port *mlxsw_sp_port, u32 handle, 
			goto err_hdroom_configure;

	}



	err = ops->check_params(mlxsw_sp_port, mlxsw_sp_qdisc, params);

	err = ops->check_params(mlxsw_sp_port, params);

	if (err)

		goto err_bad_param;
@@ -434,7 +433,6 @@ mlxsw_sp_qdisc_red_destroy(struct mlxsw_sp_port *mlxsw_sp_port, 


static int

mlxsw_sp_qdisc_red_check_params(struct mlxsw_sp_port *mlxsw_sp_port,

				struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

				void *params)

{

	struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
@@ -678,7 +676,6 @@ mlxsw_sp_qdisc_tbf_rate_kbps(struct tc_tbf_qopt_offload_replace_params *p) 


static int

mlxsw_sp_qdisc_tbf_check_params(struct mlxsw_sp_port *mlxsw_sp_port,

				struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

				void *params)

{

	struct tc_tbf_qopt_offload_replace_params *p = params;
@@ -813,7 +810,6 @@ mlxsw_sp_qdisc_fifo_destroy(struct mlxsw_sp_port *mlxsw_sp_port, 


static int

mlxsw_sp_qdisc_fifo_check_params(struct mlxsw_sp_port *mlxsw_sp_port,

				 struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

				 void *params)

{

	return 0;
@@ -948,7 +944,6 @@ __mlxsw_sp_qdisc_ets_check_params(unsigned int nbands) 


static int

mlxsw_sp_qdisc_prio_check_params(struct mlxsw_sp_port *mlxsw_sp_port,

				 struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

				 void *params)

{

	struct tc_prio_qopt_offload_params *p = params;
@@ -1124,7 +1119,6 @@ static struct mlxsw_sp_qdisc_ops mlxsw_sp_qdisc_ops_prio = { 


static int

mlxsw_sp_qdisc_ets_check_params(struct mlxsw_sp_port *mlxsw_sp_port,

				struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,

				void *params)

{

	struct tc_ets_qopt_offload_replace_params *p = params;