Commit 17b53f10 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

Revert "modpost: skip ELF local symbols during section mismatch check" 



This reverts commit a4d26f1a.

The variable 'fromsym' never starts with ".L" since commit 87e5b1e8
("module: Sync code of is_arm_mapping_symbol()").

In other words, Pattern 6 is now dead code.

Previously, the .LANCHOR1 hid the symbols listed in Pattern 2.

87e5b1e8 provided a better solution.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
parent c584476d

scripts/mod/modpost.c

+0 −12
Original line number Diff line number Diff line
@@ -1034,14 +1034,6 @@ static const struct sectioncheck *section_mismatch( 
 *   fromsec = text section

 *   refsymname = *.constprop.*

 *

 * Pattern 6:

 *   Hide section mismatch warnings for ELF local symbols.  The goal

 *   is to eliminate false positive modpost warnings caused by

 *   compiler-generated ELF local symbol names such as ".LANCHOR1".

 *   Autogenerated symbol names bypass modpost's "Pattern 2"

 *   whitelisting, which relies on pattern-matching against symbol

 *   names to work.  (One situation where gcc can autogenerate ELF

 *   local symbols is when "-fsection-anchors" is used.)

 **/

static int secref_whitelist(const struct sectioncheck *mismatch,

			    const char *fromsec, const char *fromsym,
@@ -1092,10 +1084,6 @@ static int secref_whitelist(const struct sectioncheck *mismatch, 
	    match(fromsym, optim_symbols))

		return 0;



	/* Check for pattern 6 */

	if (strstarts(fromsym, ".L"))

		return 0;



	return 1;

}