Commit 17a1eab7 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda/tas2781: Fix PM refcount unbalance at tas2781_hda_bind() 



The error path of tas2781_hda_bind() needs to release PM refcount as
well.  Modify the code flow to handle properly.

Fixes: 5be27f1e ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Reported-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Closes: https://lore.kernel.org/r/9f910785-e856-1539-e3e4-c9817af5fe67@linux.intel.com
Link: https://lore.kernel.org/r/20230820172635.22236-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1c80cc05

sound/pci/hda/tas2781_hda_i2c.c

+3 −5
Original line number Diff line number Diff line
@@ -608,15 +608,13 @@ static int tas2781_hda_bind(struct device *dev, struct device *master, 
	strscpy(comps->name, dev_name(dev), sizeof(comps->name));



	ret = tascodec_init(tas_priv, codec, tasdev_fw_ready);

	if (ret)

		return ret;



	if (!ret)

		comps->playback_hook = tas2781_hda_playback_hook;



	pm_runtime_mark_last_busy(dev);

	pm_runtime_put_autosuspend(dev);



	return 0;

	return ret;

}



static void tas2781_hda_unbind(struct device *dev,