Commit 178ce94a authored by Colin Ian King's avatar Colin Ian King Committed by Tvrtko Ursulin
Browse files

drm/i915/gem: remove redundant assignments to variable ret 



The variable ret is being assigned with a value that is never read
both before and after a while-loop. The variable is being re-assigned
inside the while-loop and afterwards on the call to the function
i915_gem_object_lock_interruptible. Remove the redundants assignments.

Cleans up clang scan-build warnings:

warning: Although the value stored to 'ret' is used in the
enclosing expression, the value is never actually read
from 'ret' [deadcode.DeadStores]

warning: Value stored to 'ret' is never read [deadcode.DeadStores]

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221007194745.2749277-1-colin.i.king@gmail.com
parent 0da9493e

drivers/gpu/drm/i915/gem/i915_gem_userptr.c

+1 −2
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) 
	if (!i915_gem_object_is_readonly(obj))

		gup_flags |= FOLL_WRITE;



	pinned = ret = 0;

	pinned = 0;

	while (pinned < num_pages) {

		ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE,

					  num_pages - pinned, gup_flags,
@@ -302,7 +302,6 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) 


		pinned += ret;

	}

	ret = 0;



	ret = i915_gem_object_lock_interruptible(obj, NULL);

	if (ret)