Unverified Commit 1788a152 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: rsnd: incidate irq error message 



Current rsnd is using dev_dbg() if irq error happen,
but it makes debug very difficult if some strange things happen.
This patch uses dev_info() for it, and rename the macro name.

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Message-Id: <87zgwglwyv.wl-kuninori.morimoto.gx@renesas.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9ff07d19

sound/soc/sh/rcar/rsnd.h

+3 −2
Original line number Diff line number Diff line
@@ -881,9 +881,10 @@ void rsnd_mod_make_sure(struct rsnd_mod *mod, enum rsnd_mod_type type); 
 *

 * #define RSND_DEBUG_NO_IRQ_STATUS 1

 */

#define rsnd_dbg_irq_status(dev, param...)		\

#define rsnd_print_irq_status(dev, param...) do {	\

	if (!IS_BUILTIN(RSND_DEBUG_NO_IRQ_STATUS))	\

		dev_dbg(dev, param)

		dev_info(dev, param);			\

} while (0)



/*

 * If you don't need rsnd_dai_call debug message,

sound/soc/sh/rcar/src.c

+3 −3
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ 
/*

 * you can enable below define if you don't need

 * SSI interrupt status debug message when debugging

 * see rsnd_dbg_irq_status()

 * see rsnd_print_irq_status()

 *

 * #define RSND_DEBUG_NO_IRQ_STATUS 1

 */
@@ -421,7 +421,7 @@ static bool rsnd_src_error_occurred(struct rsnd_mod *mod) 
	status0 = rsnd_mod_read(mod, SCU_SYS_STATUS0);

	status1 = rsnd_mod_read(mod, SCU_SYS_STATUS1);

	if ((status0 & val0) || (status1 & val1)) {

		rsnd_dbg_irq_status(dev, "%s err status : 0x%08x, 0x%08x\n",

		rsnd_print_irq_status(dev, "%s err status : 0x%08x, 0x%08x\n",

				      rsnd_mod_name(mod), status0, status1);



		ret = true;

sound/soc/sh/rcar/ssi.c

+7 −7
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ 
/*

 * you can enable below define if you don't need

 * SSI interrupt status debug message when debugging

 * see rsnd_dbg_irq_status()

 * see rsnd_print_irq_status()

 *

 * #define RSND_DEBUG_NO_IRQ_STATUS 1

 */
@@ -418,7 +418,7 @@ static bool rsnd_ssi_busif_err_status_clear(struct rsnd_mod *mod) 
			status &= 0xf << (id * 4);



			if (status) {

				rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",

				rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",

						      rsnd_mod_name(mod), status);

				rsnd_mod_write(mod,

					       SSI_SYS_STATUS(i * 2),
@@ -433,7 +433,7 @@ static bool rsnd_ssi_busif_err_status_clear(struct rsnd_mod *mod) 
			status &= 0xf << 4;



			if (status) {

				rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",

				rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",

						      rsnd_mod_name(mod), status);

				rsnd_mod_write(mod,

					       SSI_SYS_STATUS((i * 2) + 1),
@@ -782,7 +782,7 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod, 


	/* DMA only */

	if (is_dma && (status & (UIRQ | OIRQ))) {

		rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",

		rsnd_print_irq_status(dev, "%s err status : 0x%08x\n",

				      rsnd_mod_name(mod), status);



		stop = true;