Commit 17866bc6 authored by Zhen Lei's avatar Zhen Lei Committed by Vinod Koul
Browse files

dmaengine: fsl-dpaa2-qdma: Fix error return code in two functions 



Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in the function where it is.

Fixes: 7fdf9b05 ("dmaengine: fsl-dpaa2-qdma: Add NXP dpaa2 qDMA controller driver for Layerscape SoCs")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210508030056.2027-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 077cdb35

drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c

+3 −0
Original line number Diff line number Diff line
@@ -332,6 +332,7 @@ static int __cold dpaa2_qdma_setup(struct fsl_mc_device *ls_dev) 
	}



	if (priv->dpdmai_attr.version.major > DPDMAI_VER_MAJOR) {

		err = -EINVAL;

		dev_err(dev, "DPDMAI major version mismatch\n"

			     "Found %u.%u, supported version is %u.%u\n",

				priv->dpdmai_attr.version.major,
@@ -341,6 +342,7 @@ static int __cold dpaa2_qdma_setup(struct fsl_mc_device *ls_dev) 
	}



	if (priv->dpdmai_attr.version.minor > DPDMAI_VER_MINOR) {

		err = -EINVAL;

		dev_err(dev, "DPDMAI minor version mismatch\n"

			     "Found %u.%u, supported version is %u.%u\n",

				priv->dpdmai_attr.version.major,
@@ -475,6 +477,7 @@ static int __cold dpaa2_qdma_dpio_setup(struct dpaa2_qdma_priv *priv) 
		ppriv->store =

			dpaa2_io_store_create(DPAA2_QDMA_STORE_SIZE, dev);

		if (!ppriv->store) {

			err = -ENOMEM;

			dev_err(dev, "dpaa2_io_store_create() failed\n");

			goto err_store;

		}