Commit 1775c7dd authored by Jeff Layton's avatar Jeff Layton Committed by Ilya Dryomov
Browse files

ceph: fix inode leak on getattr error in __fh_to_dentry 



Fixes: 878dabb6 ("ceph: don't return -ESTALE if there's still an open file")
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarXiubo Li <xiubli@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent e9b22501

fs/ceph/export.c

+3 −1
Original line number Diff line number Diff line
@@ -178,8 +178,10 @@ static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino) 
		return ERR_CAST(inode);

	/* We need LINK caps to reliably check i_nlink */

	err = ceph_do_getattr(inode, CEPH_CAP_LINK_SHARED, false);

	if (err)

	if (err) {

		iput(inode);

		return ERR_PTR(err);

	}

	/* -ESTALE if inode as been unlinked and no file is open */

	if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) {

		iput(inode);