Commit 1764ce06 authored by James Clark's avatar James Clark Committed by Arnaldo Carvalho de Melo
Browse files

perf cs-etm: Use bool type for boolean values 



Using u8 for boolean values makes the code a bit more difficult to read
so be more explicit by using bool.

Signed-off-by: default avatarJames Clark <james.clark@arm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Denis Nikitin <denik@google.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20230424134748.228137-7-james.clark@arm.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7bfc1544

tools/perf/util/cs-etm-decoder/cs-etm-decoder.h

+4 −4
Original line number Diff line number Diff line
@@ -60,10 +60,10 @@ struct cs_etm_decoder_params { 
	int operation;

	void (*packet_printer)(const char *msg);

	cs_etm_mem_cb_type mem_acc_cb;

	u8 formatted;

	u8 fsyncs;

	u8 hsyncs;

	u8 frame_aligned;

	bool formatted;

	bool fsyncs;

	bool hsyncs;

	bool frame_aligned;

	void *data;

};

tools/perf/util/cs-etm.c

+4 −4
Original line number Diff line number Diff line
@@ -50,10 +50,10 @@ struct cs_etm_auxtrace { 
	struct thread *unknown_thread;

	struct perf_tsc_conversion tc;



	u8 timeless_decoding;

	u8 snapshot_mode;

	u8 data_queued;

	u8 has_virtual_ts; /* Virtual/Kernel timestamps in the trace. */

	bool timeless_decoding;

	bool snapshot_mode;

	bool data_queued;

	bool has_virtual_ts; /* Virtual/Kernel timestamps in the trace. */



	int num_cpu;

	u64 latest_kernel_timestamp;

tools/perf/util/cs-etm.h

+2 −2
Original line number Diff line number Diff line
@@ -179,8 +179,8 @@ struct cs_etm_packet { 
	u32 last_instr_subtype;

	u32 flags;

	u32 exception_number;

	u8 last_instr_cond;

	u8 last_instr_taken_branch;

	bool last_instr_cond;

	bool last_instr_taken_branch;

	u8 last_instr_size;

	u8 trace_chan_id;

	int cpu;