Commit 1753c4d1 authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

of: property: Don't add links to absent suppliers 



If driver core marks a firmware node as not a device, don't add fwnode
links where it's a supplier.

Fixes: e5904747 ("driver core: Set fw_devlink=on by default")
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20210205222644.2357303-3-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9528e0d9

drivers/of/property.c

+3 −1
Original line number Diff line number Diff line
@@ -1103,7 +1103,9 @@ static int of_link_to_phandle(struct device_node *con_np, 
	 * created for them.

	 */

	sup_dev = get_dev_from_fwnode(&sup_np->fwnode);

	if (!sup_dev && of_node_check_flag(sup_np, OF_POPULATED)) {

	if (!sup_dev &&

	    (of_node_check_flag(sup_np, OF_POPULATED) ||

	     sup_np->fwnode.flags & FWNODE_FLAG_NOT_DEVICE)) {

		pr_debug("Not linking %pOFP to %pOFP - No struct device\n",

			 con_np, sup_np);

		of_node_put(sup_np);