Commit 1751fc1d authored by Trond Myklebust's avatar Trond Myklebust Committed by Anna Schumaker
Browse files

NFSv4: nfs_atomic_open() can race when looking up a non-regular file 



If the file type changes back to being a regular file on the server
between the failed OPEN and our LOOKUP, then we need to re-run the OPEN.

Fixes: 0dd2b474 ("nfs: implement i_op->atomic_open()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent ac795161

fs/nfs/dir.c

+5 −0
Original line number Diff line number Diff line
@@ -1999,12 +1999,17 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry, 
		if ((lookup_flags & LOOKUP_DIRECTORY) && inode &&

		    !S_ISDIR(inode->i_mode))

			res = ERR_PTR(-ENOTDIR);

		else if (inode && S_ISREG(inode->i_mode))

			res = ERR_PTR(-EOPENSTALE);

	} else if (!IS_ERR(res)) {

		inode = d_inode(res);

		if ((lookup_flags & LOOKUP_DIRECTORY) && inode &&

		    !S_ISDIR(inode->i_mode)) {

			dput(res);

			res = ERR_PTR(-ENOTDIR);

		} else if (inode && S_ISREG(inode->i_mode)) {

			dput(res);

			res = ERR_PTR(-EOPENSTALE);

		}

	}

	if (switched) {