Commit 17500695 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: qcom: add IRQ check 



In dwc3_qcom_acpi_register_core(), the driver neglects to check the result
of platform_get_irq()'s call and blithely assigns the negative error codes
to the allocated child device's IRQ resource and then passing this resource
to platform_device_add_resources() and later causing dwc3_otg_get_irq() to
fail anyway.  Stop calling platform_device_add_resources() with the invalid
IRQ #s, so that there's less complexity in the IRQ error checking.

Fixes: 2bc02355 ("usb: dwc3: qcom: Add support for booting with ACPI")
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/45fec3da-1679-5bfe-5d74-219ca3fb28e7@omp.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent baa2986b

drivers/usb/dwc3/dwc3-qcom.c

+4 −0
Original line number Diff line number Diff line
@@ -614,6 +614,10 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev) 
		qcom->acpi_pdata->dwc3_core_base_size;



	irq = platform_get_irq(pdev_irq, 0);

	if (irq < 0) {

		ret = irq;

		goto out;

	}

	child_res[1].flags = IORESOURCE_IRQ;

	child_res[1].start = child_res[1].end = irq;