Commit 172e269e authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: ef10: fix TX queue lookup in TX event handling 



We're starting from a TXQ label, not a TXQ type, so
 efx_channel_get_tx_queue() is inappropriate.  This worked by chance,
 because labels and types currently match on EF10, but we shouldn't
 rely on that.

Fixes: 12804793 ("sfc: decouple TXQ type from label")
Signed-off-by: default avatarEdward Cree <ecree.xilinx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 83b09a18

drivers/net/ethernet/sfc/ef10.c

+1 −2
Original line number Diff line number Diff line
@@ -2928,8 +2928,7 @@ efx_ef10_handle_tx_event(struct efx_channel *channel, efx_qword_t *event) 


	/* Get the transmit queue */

	tx_ev_q_label = EFX_QWORD_FIELD(*event, ESF_DZ_TX_QLABEL);

	tx_queue = efx_channel_get_tx_queue(channel,

					    tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);

	tx_queue = channel->tx_queue + (tx_ev_q_label % EFX_MAX_TXQ_PER_CHANNEL);



	if (!tx_queue->timestamping) {

		/* Transmit completion */