Commit 170b7d2d authored by Tom Rix's avatar Tom Rix Committed by Martin K. Petersen
Browse files

scsi: Remove unneeded break statements 

A break is not needed if it is preceded by a return or goto.

Link: https://lore.kernel.org/r/20201019142333.16584-1-trix@redhat.com


Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 434ee425

drivers/scsi/aic94xx/aic94xx_task.c

+0 −1
Original line number Diff line number Diff line
@@ -269,7 +269,6 @@ static void asd_task_tasklet_complete(struct asd_ascb *ascb, 
	case TA_I_T_NEXUS_LOSS:

		opcode = dl->status_block[0];

		goto Again;

		break;

	case TF_INV_CONN_HANDLE:

		ts->resp = SAS_TASK_UNDELIVERED;

		ts->stat = SAS_DEVICE_UNKNOWN;

drivers/scsi/be2iscsi/be_mgmt.c

+0 −4
Original line number Diff line number Diff line
@@ -1244,18 +1244,14 @@ beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr, 
	case OC_DEVICE_ID2:

		return snprintf(buf, PAGE_SIZE,

				"Obsolete/Unsupported BE2 Adapter Family\n");

		break;

	case BE_DEVICE_ID2:

	case OC_DEVICE_ID3:

		return snprintf(buf, PAGE_SIZE, "BE3-R Adapter Family\n");

		break;

	case OC_SKH_ID1:

		return snprintf(buf, PAGE_SIZE, "Skyhawk-R Adapter Family\n");

		break;

	default:

		return snprintf(buf, PAGE_SIZE,

				"Unknown Adapter Family: 0x%x\n", dev_id);

		break;

	}

}

drivers/scsi/bnx2fc/bnx2fc_hwi.c

+0 −1
Original line number Diff line number Diff line
@@ -770,7 +770,6 @@ static void bnx2fc_process_unsol_compl(struct bnx2fc_rport *tgt, u16 wqe) 
			} else

				printk(KERN_ERR PFX "SRR in progress\n");

			goto ret_err_rqe;

			break;

		default:

			break;

		}

drivers/scsi/fcoe/fcoe.c

+0 −1
Original line number Diff line number Diff line
@@ -1894,7 +1894,6 @@ static int fcoe_device_notification(struct notifier_block *notifier, 
		mutex_unlock(&fcoe_config_mutex);

		fcoe_ctlr_device_delete(fcoe_ctlr_to_ctlr_dev(ctlr));

		goto out;

		break;

	case NETDEV_FEAT_CHANGE:

		fcoe_netdev_features_change(lport, netdev);

		break;

drivers/scsi/hpsa.c

+0 −1
Original line number Diff line number Diff line
@@ -7442,7 +7442,6 @@ static int find_PCI_BAR_index(struct pci_dev *pdev, unsigned long pci_bar_addr) 
				dev_warn(&pdev->dev,

				       "base address is invalid\n");

				return -1;

				break;

			}

		}

		if (offset == pci_bar_addr - PCI_BASE_ADDRESS_0)