Commit 170b2223 authored by José Expósito's avatar José Expósito Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc 



The function performs a check on the "ctx" input parameter, however, it
is used before the check.

Initialize the "base" variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 4259ff7a ("drm/msm/dpu: add support for pcc color block in dpu driver")
Addresses-Coverity-ID: 1493866 ("Null pointer dereference")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Link: https://lore.kernel.org/r/20220109192431.135949-1-jose.exposito89@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 774fe0cd

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c

+9 −2
Original line number Diff line number Diff line
@@ -26,9 +26,16 @@ static void dpu_setup_dspp_pcc(struct dpu_hw_dspp *ctx, 
		struct dpu_hw_pcc_cfg *cfg)

{



	u32 base = ctx->cap->sblk->pcc.base;

	u32 base;



	if (!ctx || !base) {

	if (!ctx) {

		DRM_ERROR("invalid ctx %pK\n", ctx);

		return;

	}



	base = ctx->cap->sblk->pcc.base;



	if (!base) {

		DRM_ERROR("invalid ctx %pK pcc base 0x%x\n", ctx, base);

		return;

	}