Commit 170277c5 authored by Ziyang Xuan's avatar Ziyang Xuan Committed by Marc Kleine-Budde
Browse files

can: raw: use guard clause to optimize nesting in raw_rcv() 



We can use guard clause to optimize nesting codes like
if (condition) { ... } else { return; } in raw_rcv();

Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Link: https://lore.kernel.org/all/0170ad1f07dbe838965df4274fce950980fa9d1f.1661584485.git.william.xuanziyang@huawei.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c28b3bff

net/can/raw.c

+6 −7
Original line number Diff line number Diff line
@@ -136,14 +136,13 @@ static void raw_rcv(struct sk_buff *oskb, void *data) 
	/* eliminate multiple filter matches for the same skb */

	if (this_cpu_ptr(ro->uniq)->skb == oskb &&

	    this_cpu_ptr(ro->uniq)->skbcnt == can_skb_prv(oskb)->skbcnt) {

		if (ro->join_filters) {

		if (!ro->join_filters)

			return;



		this_cpu_inc(ro->uniq->join_rx_count);

		/* drop frame until all enabled filters matched */

		if (this_cpu_ptr(ro->uniq)->join_rx_count < ro->count)

			return;

		} else {

			return;

		}

	} else {

		this_cpu_ptr(ro->uniq)->skb = oskb;

		this_cpu_ptr(ro->uniq)->skbcnt = can_skb_prv(oskb)->skbcnt;